Deposit function should be disabled before starting a game
The deposit function was enabled before the user clicked 'Start Game', allowing transactions to be submitted with no active game session and creating an unnecessary gas griefing surface.
Description
Enabling the deposit function before the user initiates the game with "Start Game" can lead to unnecessary transactions and potential gas griefing. Users could trigger deposits without an active session, consuming gas without any meaningful application state change.
Impact
Gas griefing surface; unintended transactions submitted without an active game session. No direct fund-loss vector but a robustness and UX failure.
Recommendation
Disable the deposit function in the UI and at the API boundary until a game session has been started. Reject deposit attempts that arrive before the session-start transition.
Hopium: Acknowledged. Zealynx: Acknowledged.