SubscriptionCreated event missing co-ownership parameters
The SubscriptionCreated event omits coOwner and splitFee, preventing off-chain services from tracking co-ownership configuration purely from events.
Description
The SubscriptionCreated event does not emit the coOwner and splitFee parameters that are passed to the setSubscription function. This prevents off-chain services from tracking co-ownership details when subscriptions are created.
emit SubscriptionCreated(msg.sender, vaultId, price, expirationDuration);
Additionally, these parameters lack NatSpec documentation. The function accepts coOwner and splitFee parameters but they are not included in the event emission or properly documented.
Off-chain services and indexers cannot track co-ownership details from events alone, requiring additional contract calls to retrieve this information. This reduces the utility of events for monitoring subscription creation and increases the complexity of integrating with the protocol.
Impact
Reduced indexer and analytics utility around co-ownership; integration partners must perform additional contract reads to reconstruct subscription state.
Recommendation
Update the SubscriptionCreated event definition and emission to include the missing parameters:
emit SubscriptionCreated(msg.sender, vaultId, price, expirationDuration, coOwner, splitFee);
Resolution
Ipal Network: Confirmed. We agreed with the recommendation, and the SubscriptionCreated and SubscriptionUpdated events have been updated to include the coOwner and splitFee parameters.
Zealynx: Fixed. The SubscriptionCreated and SubscriptionUpdated events now properly include the coOwner and splitFee parameters in both their definitions and emissions, enabling off-chain services to track co-ownership details when subscriptions are created or updated.

