Missing parent contract initialization in upgradeable contract

The contract is currently implemented as a non-upgradeable contract: it uses non-upgradeable parent contracts (ReentrancyGuard) instead of their upgradeable versions (ReentrancyGuardUpgradeable) and fails to initialize parent contracts properly. This creates two issues:

1. Wrong contract type: Uses ReentrancyGuard which has a constructor that sets _status = _NOT_ENTERED in implementation contract storage, not proxy storage.
2. Missing parent initialization: The initialize() function does not call parent initializers.

Current problematic code:

// Wrong import: should be ReentrancyGuardUpgradeable
import {ReentrancyGuard} from "@openzeppelin/contracts/utils/ReentrancyGuard.sol";

// Using non-upgradeable contract
contract KnowledgeMarket is Initializable, ERC4908, ReentrancyGuard {

// Missing parent initializations
function initialize(address payable _treasury, uint32 _fee) public initializer {
    if (_treasury == address(0)) revert ZeroAddress();
    if (_fee > 10000) revert InvalidFee();

    platformTreasury = _treasury;
    platformFeePercent = _fee;
    // Missing: __ERC721_init(), __ReentrancyGuard_init()
}

• ReentrancyGuard constructor sets _status = 1 in implementation contract storage.
• In a proxy pattern, this initialization happens in the wrong storage context.
• ReentrancyGuardUpgradeable requires explicit __ReentrancyGuard_init() call.
• Without proper initialization, _status defaults to 0, but nonReentrant modifier checks _status != _ENTERED (2), so it still works by accident.

Inconsistent storage layout in upgradeable proxy patterns; latent reentrancy guard semantics depend on default values rather than explicit initialization, complicating future upgrades.

1. Change imports to upgradeable versions (ReentrancyGuardUpgradeable).
2. Update contract inheritance.
3. Initialize all parent contracts properly in initialize:

function initialize(address payable _treasury, uint32 _fee) public initializer {
    __ERC721_init("Knowledge Market Access", "KMA");
    __ERC721Enumerable_init();
    __ReentrancyGuard_init();

    if (_treasury == address(0)) revert ZeroAddress();
    if (_fee > 10000) revert InvalidFee();

    platformTreasury = _treasury;
    platformFeePercent = _fee;
}

Ipal Network: Confirmed. We agreed with the recommendation.

Zealynx: Not Fixed: The KnowledgeMarket.sol contract still lacks proper parent contract initialization. It should use ReentrancyGuardUpgradeable and call __ReentrancyGuard_init() in the initialize function.

UPDATE: Fixed.