Tier updates not reflected in lockPeriods array leads to stale staking period information

The StakingContract maintains staking period information in two separate data structures: tiers and lockPeriods. When updating tiers through the updateTier function, the corresponding lockPeriods array is not updated to reflect these changes:

function updateTier(uint numDays, uint basisPoints) external onlyOwner {
    require(basisPoints <= 10000, "Invalid basis points");
    uint oldRate = tiers[numDays];
    tiers[numDays] = basisPoints;
    // lockPeriods is not updated here
    emit TierUpdated(numDays, oldRate, basisPoints);
}

This creates a misalignment between the actual available staking periods in tiers and what is exposed through the getLockPeriods() function:

function getLockPeriods() external view returns (uint[] memory) {
    return lockPeriods;  // Returns stale data that doesn't reflect tier updates
}

• Stale Data: getLockPeriods() returns outdated information that does not reflect the current state of available staking periods after tier updates.
• UI / Integration Inconsistency: Users and integrated protocols receive incorrect information about available staking periods because getLockPeriods() does not reflect updates made through updateTier.
• Protocol Confusion: Creates confusion about which staking periods are actually valid, as the two data structures maintain different states.

Modify updateTier to maintain synchronisation between tiers and lockPeriods:

function updateTier(uint numDays, uint basisPoints) external onlyOwner {
    require(basisPoints <= 10000, "Invalid basis points");

    uint oldRate = tiers[numDays];

    // If this is a new period, add it to lockPeriods
    if (tiers[numDays] == 0) {
        lockPeriods.push(numDays);
    }

    // Update the tier
    tiers[numDays] = basisPoints;

    emit TierUpdated(numDays, oldRate, basisPoints);
}

Ample Protocol: Fixed.

Zealynx: Verified.