F-2025-0014·code-quality
Inconsistent terminology between rewards and interest
TL;DR
Contract uses both 'rewards' and 'interest' terminology for the same concept across functions, structs, events, and helpers, causing reader confusion.
Severity
INFO
Impact
LOW
Likelihood
LOW
Method
MManual review
CAT.
Complexity
LOW
Exploitability
LOW
02Section · Description
Description
The contract uses both "rewards" and "interest" terms interchangeably, which could lead to confusion. For example:
solidity
// Uses "rewards" terminologyfunction fundRewards(uint256 amount) external onlyOwner {// ...}event RewardsFunded(address indexed funder, uint256 amount);// But uses "interest" terminologystruct Position {uint256 tokensInterest; // Should be tokensRewarduint256 percentInterest; // Should be percentReward}function calculateInterest(uint basisPoints, uint tokenAmount) private pure {// Should be calculateReward}
The protocol documentation and UI refer to these as "rewards", so the contract should maintain consistency with this terminology.
03Section · Recommendation
Recommendation
Align all variable and function names to use "reward" terminology.

